Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: camunda 8 extension issue .bpmn #4663

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

abdul99ahad
Copy link
Contributor

@abdul99ahad abdul99ahad commented Nov 4, 2024

Closes #4661

Proposed Changes

Nov-04-2024 19-20-22

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

This Pull Request targets develop branch, but contains fix commits.

Consider targeting main instead.

@abdul99ahad abdul99ahad changed the base branch from develop to main November 4, 2024 14:38
@nikku
Copy link
Member

nikku commented Nov 4, 2024

@abdul99ahad Checking the number of commits on this PR something does not seem to be quite right.

@abdul99ahad abdul99ahad force-pushed the extension-issue-camunda8 branch 2 times, most recently from ac5b119 to 0475c2d Compare November 5, 2024 08:19
@abdul99ahad
Copy link
Contributor Author

@abdul99ahad Checking the number of commits on this PR something does not seem to be quite right.

Now it's all right. Rebased to main

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean. I added an update to the CHANGELOG.

@nikku nikku merged commit 7f8a3fa into main Nov 5, 2024
9 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 5, 2024
@nikku nikku deleted the extension-issue-camunda8 branch November 5, 2024 20:28
@github-actions github-actions bot added this to the M83 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Without file extension Camunda 8 diagrams save with .cloud-bpmn extension
2 participants